fix: don't fail the upload when the branch is not on origin#349
Merged
gregberge merged 3 commits intoJul 23, 2026
Merged
Conversation
…igin Running the upload from a branch that is not pushed yet made getMergeBaseCommitSha die on `git fetch` (exit 128, "couldn't find remote ref"), killing the whole upload. It was the only link in the baseline resolution chain that could throw. Fetch failures now fall back to the local history instead of failing: - ref missing on origin (e.g. branch not pushed yet): use the local ref, which is the exact state being built; expected, logged in debug only. - other failures (network, auth…): keep the freshest fetched state when available, fall back to the local ref otherwise, and surface a warning. When a ref is unavailable both on origin and locally, the merge base resolves to null, which produces a build without baseline as the rest of the chain already handles. Closes ARG-472 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Vitest decides the exit code before reporters run onTestRunEnd, so an error thrown by the Argos reporter surfaced as an "Unhandled Error" while the process still exited 0: green tests, no build, no signal. The reporter now catches upload errors, reports them and fails the run explicitly through process.exitCode. A new ignoreUploadFailures option (same as the Playwright reporter) keeps the run green when wanted. Closes ARG-472 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gregberge
deleted the
greg/arg-472-first-local-run-fails-on-a-feature-branch
branch
July 23, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ARG-472: running the upload locally from a branch that isn't pushed yet killed the run with
fatal: couldn't find remote ref <branch>— and the process still exited 0, so users saw green tests and no build.core: merge-base resolution never fails the upload
getMergeBaseCommitShawas the only link in the baseline resolution chain that could throw: it fetched the head/base refs without catching failures. Fetch failures now fall back to the local history:null→ build without baseline, asresolveBaselineandlistAncestorCommitsalready handle.vitest: upload failures fail the run instead of exiting 0
Vitest decides the exit code before reporters run
onTestRunEnd, so a throwing reporter surfaced as an "Unhandled Error" while the process exited 0. The reporter now catches upload errors, reports them and setsprocess.exitCode = 1. A newignoreUploadFailuresoption (mirroring the Playwright reporter) opts out of failing the run.Test plan
nullwithout throwing, unreachable origin falls back to local history with a warningignoreUploadFailureskeeps it unset and is not forwarded toupload()poc-argosbranch): merge base resolved, no crashcheck-types,lint, full unit suites ofcore(116) andvitest(45) pass🤖 Generated with Claude Code