Skip to content

fix: update react-toastify for React 19 compatibility - #626

Merged
blakepettersson merged 1 commit into
argoproj:masterfrom
choejwoo:fix/react-toastify-react-19
Jul 23, 2026
Merged

fix: update react-toastify for React 19 compatibility#626
blakepettersson merged 1 commit into
argoproj:masterfrom
choejwoo:fix/react-toastify-react-19

Conversation

@choejwoo

Copy link
Copy Markdown
Member

Related to argoproj/argo-cd#28749

Update react-toastify from v9.0.3 to v11.1.0 for React 19 compatibility.

React Toastify v9 relies on function component defaultProps, which are not applied when using React 19 with the automatic JSX runtime. This causes transition to be undefined and crashes the UI whenever a toast is rendered.

This also replaces the removed toast.POSITION.BOTTOM_RIGHT constant with the equivalent bottom-right position value.

After this PR is merged, I will update the argo-ui commit referenced by Argo CD and align its direct react-toastify dependency with v11 in a follow-up PR.

스크린샷 2026-07-22 오후 7 46 34

Signed-off-by: choejwoo <jaewoo45@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates react-toastify to a React 19–compatible version and adjusts notification code to match the updated library API, preventing toast rendering crashes under React 19 + automatic JSX runtime.

Changes:

  • Bump react-toastify from 9.0.3 to 11.1.0.
  • Replace toast.POSITION.BOTTOM_RIGHT with the equivalent string value 'bottom-right'.
  • Update pnpm-lock.yaml to reflect the dependency upgrade (including updated transitive deps like clsx).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/components/notifications/notifications.tsx Updates toast position configuration to the v11-compatible string value.
package.json Bumps react-toastify to 11.1.0.
pnpm-lock.yaml Locks the new react-toastify version and updated transitive dependency graph.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@blakepettersson blakepettersson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakepettersson
blakepettersson merged commit ddb3173 into argoproj:master Jul 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants