fix: update react-toastify for React 19 compatibility - #626
Merged
blakepettersson merged 1 commit intoJul 23, 2026
Conversation
Signed-off-by: choejwoo <jaewoo45@gmail.com>
There was a problem hiding this comment.
Pull request overview
Updates react-toastify to a React 19–compatible version and adjusts notification code to match the updated library API, preventing toast rendering crashes under React 19 + automatic JSX runtime.
Changes:
- Bump
react-toastifyfrom9.0.3to11.1.0. - Replace
toast.POSITION.BOTTOM_RIGHTwith the equivalent string value'bottom-right'. - Update
pnpm-lock.yamlto reflect the dependency upgrade (including updated transitive deps likeclsx).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/notifications/notifications.tsx | Updates toast position configuration to the v11-compatible string value. |
| package.json | Bumps react-toastify to 11.1.0. |
| pnpm-lock.yaml | Locks the new react-toastify version and updated transitive dependency graph. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to argoproj/argo-cd#28749
Update
react-toastifyfrom v9.0.3 to v11.1.0 for React 19 compatibility.React Toastify v9 relies on function component
defaultProps, which are not applied when using React 19 with the automatic JSX runtime. This causestransitionto beundefinedand crashes the UI whenever a toast is rendered.This also replaces the removed
toast.POSITION.BOTTOM_RIGHTconstant with the equivalentbottom-rightposition value.After this PR is merged, I will update the
argo-uicommit referenced by Argo CD and align its directreact-toastifydependency with v11 in a follow-up PR.