feat: support creating multi-source applications in New App panel

[dvcanton]

Implements #20964 based on Proposal #17108.

Depends on a fix #581 in the FormField component.

Side note: that is my first contribution to ArgoCD, therefore I am open to improvement ideas, suggestions and discussion points on this PR.

After:

The button Add Source places a new SourcePanel component and increase a source counter.

Checklist:

• [x ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to try again to remove the environment

[andrii-korotkov-verkada]

Please, fix the tests

[nitishfy]

Can you fix the Lint issues and DCO check?

• You can fix the lint issues by running the command
  golangci-lint run --timeout 10m --fix

• If you click on “Details” next to the failed check for DCO, you’ll find instructions how to solve that.

Also, it can be helpful if you can paste a After section in the PR description.

[dvcanton]

Hi @nitishfy thanks a lot for the tip! I have been struggling with the UI lint and its requirements (spacing, line breaks, etc), hence the number of times I have rebased and repushed the same commit (btw sorry if you guys received a flood of notifications in the process @nitishfy @andrii-korotkov-verkada).

The UI tests now pass. I have also included source screenshoots in the PR description to show how the create new app panel looks like -- I hope that is what you meant with an After session, @nitishfy?

Thanks for the comments! :)

[andrii-korotkov-verkada]

btw sorry if you guys received a flood of notifications in the process

You are good.

hence the number of times I have rebased and repushed the same commit

It may be better to not force push to be able to see your incremental changes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.97%. Comparing base (02d6866) to head (680e005).
⚠️ Report is 2754 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21005      +/-   ##
==========================================
- Coverage   55.03%   54.97%   -0.07%     
==========================================
  Files         324      324              
  Lines       55466    55466              
==========================================
- Hits        30526    30492      -34     
- Misses      22330    22350      +20     
- Partials     2610     2624      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[keithchong]

Could you rebase?

Also, try reconciling or synchronizing the changes made in the yaml editor with what is on the form, and vice versa.

Are you planning to make the source sections collapsible? (It could be a follow-on PR). That way it'll be consistent with what we already have.

[keithchong]

Did you take this source from

argo-cd/ui/src/app/applications/components/application-parameters/source-panel.tsx

Line 12 in 8f0d3d0

// This is similar to what is in application-create-panel.tsx. If the create panel

? The next step is to common this up.

[keithchong]

Also, the source parameters section should dynamically update based on the app source type (eg. helm or kustomize) that we detect.

[nithin8702]

Hi @dvcanton

This PR is useful to us, Could you please resolve it and merge this changes.

[aali309]

@dvcanton — I’d like to help get this merged (rebase + conflicts + remaining review items). Are you still active on this PR? If not, I’ll open a follow-up PR based on your branch and reference #21005. Thanks for the feature work.

[aali309]

This can be closed @nitishfy