utils: rename generated version file to thapi_version - #527
Merged
Conversation
AC_CONFIG_HEADERS([utils/config.h]) makes automake prepend
-I$(top_builddir)/utils to DEFAULT_INCLUDES for every target in the
tree, ahead of the system include directories. The generated `version`
data file therefore shadows the C++20 <version> standard header.
abseil-cpp 20250127.0 added an unguarded
#if __has_include(<version>)
#include <version>
#endif
to absl/types/span.h, so any build pulling in abseil (via protobuf, for
libXTimeline's perfetto output) fails with
../utils/version:1:1: error: expected unqualified-id
even at -std=c++17. Renaming the data file avoids the collision; the
seven tracer scripts and two Ruby readers are updated to match.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ now use
versionas a official header.During code gen we generate
versionintoutils. And then do-I utils. and them kaboomThe easier change is to rename it to
thapi_version