itt: emit = {0} instead of = {} for _retval - #524
Merged
Conversation
`Type _retval = {};` is an empty initializer, which is only valid for
scalars from C23 on; older compilers reject it with "empty scalar
initializer" (gcc 12 does, gcc 13 accepts it, which is why CI never
caught this). `= {0}` zero-initializes both scalars and aggregates and
is valid well before C23, so it keeps _retval initialized -- it is read
by the tracepoint before being assigned -- without the dialect
requirement.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type _retval = {};is an empty initializer, which is only valid for scalars from C23 on; older compilers reject it with "empty scalar initializer" (gcc 12 does, gcc 13 accepts it, which is why CI never caught this).= {0}zero-initializes both scalars and aggregates and is valid well before C23, so it keeps _retval initialized.IF we move to c23 one-day, we can modernize the code.