Repository navigation
fix: the defects of the fronts script found by the code review of LUI-182 (LUI-186) - #32
Merged
Merged
Conversation
…-182 (LUI-186) The xhigh code review of the whole LUI-182 implementation found defects in the fronts script, its hook and one test. Each one has a test that fails without the fix: - novo: the new branch started with origin/main as its upstream, so a plain git push in the front suggested pushing the feature to main (--no-track) - remover: it deleted the branch with local commits made after the merge, and a merged PR of an old life of the branch hid a newer open one; it now refuses a branch whose tip is not the tip of the merged PR, prefers the open PR, and leaves the folder before removing it so it also works from inside - a front whose folder was deleted by hand (prunable) no longer counts toward the limit of three or shows in listar - hook: frentes.sh is denied with the test-mode variables (HARNESS_TEST, FRENTES_GH and the others), which swapped gh and bypassed the merge check - git-mount test: the relative .git cases need Git 2.48, while the script accepts 2.38, so they are left out below it - sincronizar: the list of what entered no longer filters by merge commits, so squashed pull requests show up Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ANcDtWf5vRMzv1r42Ax9ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que muda
Corrige os defeitos do script de frentes, do hook de antes do comando e de um teste que o
code-reviewem nívelxhighachou ao revisar toda a implementação da LUI-182 (PRs #22 a #31). Cada correção tem um teste que reprova no código antigo e passa no novo.novo: a branch nascia comorigin/maincomo upstream, e ogit pushsimples da frente sugeriagit push origin HEAD:main. Agora nasce sem upstream (--no-track).remover: apagava a branch mesmo com commits locais feitos depois do merge, e um PR mergeado antigo escondia um PR novo e aberto na mesma branch. Agora recusa se a ponta da branch não é a do PR mergeado, prefere o PR aberto, e sai da pasta antes de removê-la, então funciona também chamado de dentro da frente.prunabledeixa de contar para o limite de 3 frentes e some dolistar.frentes.shjunto das variáveis do modo de teste (HARNESS_TEST,FRENTES_GH,FRENTES_DOCKER,FRENTES_PORT_OWNER,FRENTES_GIT_VERSION), que trocavam oghe contornavam a conferência do merge.git-mount.test.sh: os casos do.gitrelativo exigem o Git 2.48, e o script aceita a partir do 2.38; abaixo disso eles ficam de fora, com um aviso./sincronizar: a lista "o que entrou" não filtra mais por merge commit, então PRs integrados por squash aparecem.Fora deste PR
A duplicação da base padrão entre
frentes.sheverify.sh, o rótulo "regra mecânica" doschema.prismae a classificação deapp.module.tse.env.examplecomo listas alfabéticas.Também fora, por ser decisão do usuário: o bloco
permissionsdo.claude/settings.json, que o commit63c24d1esvaziou.Harness
Este PR altera
scripts/e.claude/hooks/, então o checkGuarda do harnessreprova por desenho e o PR só entra por override do usuário.Verificação
scripts/verify.sh fullaprovado na máquina: 109 critérios com teste cobertos, varredura de segredos limpa.Aceite
nenhum: correção do harness, sem aceite novo; os testes novos usam as tags LUI-186-CA1, CA2, CA6 e CA7, que já existem.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ANcDtWf5vRMzv1r42Ax9ce