Repository navigation
Conversation
Contributor
|
@arflexx I checked this failure against the default-branch CI run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dedicated_nubanpayment references and amounts with matching local deposit ledger entries.Provider API scope
Paystack's documented customer and transaction endpoints expose DVA activity and customer transactions, but not a current balance for an individual dedicated account. This PR reports missing or inconsistent deposit transactions as the available reconciliation signal; it does not represent that as a running account-balance check.
Validation
npm test -- --runTestsByPath src/services/virtualAccount.test.ts src/jobs/virtualAccountReconciliation.test.ts— passed (11 tests).npm run lintremains blocked by existing notification template/type errors in unrelated files.git diff --checkand full added-line PolinRider scan — passed.Refs #492