Skip to content

fix(frontend): harden modal focus management - #594

Open
Sammyzyandev wants to merge 1 commit into
arflexx:mainfrom
Sammyzyandev:fix/issue-458
Open

Sammyzyandev wants to merge 1 commit into
arflexx:mainfrom
Sammyzyandev:fix/issue-458

Conversation

@Sammyzyandev

Copy link
Copy Markdown
Contributor

Summary

  • Add an explicit accessible name for modal dialogs without visible titles.
  • Exclude disabled, hidden, and aria-disabled controls from the focus sequence.
  • Redirect Tab focus back into the dialog if focus has moved outside, and keep the existing first/last focus wrapping and focus restoration.
  • Add tests for dialog naming, initial focus, both Tab directions, and outside-focus recovery.

Validation

  • npm test -- --runInBand components/ui/ui.test.tsx — passed (17 tests).
  • git diff --check and full added-line PolinRider scan — passed.

Closes #458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] - Add Focus Traps for Auth Modal Dialogs

1 participant