Skip to content

Add identifier and IP rate limits for OTP requests - #586

Merged
dark-sarge merged 1 commit into
arflexx:mainfrom
therealmercy-dev:fix/484-otp-request-rate-limit
Oct 26, 2026
Merged

dark-sarge merged 1 commit into
arflexx:mainfrom
therealmercy-dev:fix/484-otp-request-rate-limit

Conversation

@therealmercy-dev

@therealmercy-dev therealmercy-dev commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Enforce independent sliding-window OTP request limits per identifier and client IP, returning 429 with Retry-After when either budget is exceeded.
  • Make the request threshold and window configurable with OTP_RATE_LIMIT_MAX_REQUESTS and OTP_RATE_LIMIT_WINDOW_MINUTES.
  • Apply the limiter to both /request-otp and recovery phone changes before account mutation or SMS delivery.
  • Add IP persistence and indexes through migration 016_otp_rate_limit_ip.sql, including support for email-length identifiers.
  • Add tests for identifier and IP throttling, plus coverage that recovery OTP requests invoke the limiter.

Validation

  • TypeScript diagnostics and git diff --check passed.

Closes #484

@drips-wave

drips-wave Bot commented Oct 22, 2026

Copy link
Copy Markdown

@therealmercy-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@dark-sarge
dark-sarge merged commit 4dabc81 into arflexx:main Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Backend] - Add Rate Limiting for OTP Request Endpoints

2 participants