Repository navigation
ci: harden re-runs - #704
Merged
Merged
Conversation
When a board has a FAILURE test (e.g. an empty test report), the summary listed all of its tests, including the passing ones with no issues, causing an IndexError on test.issues[0]. Only list the failed tests. Also fix a missing f-string prefix in the "empty test report" message. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Memory usage change @ 65690de
Click for full report table
Click for full report CSV |
Each re-run attempt uploads its artifacts with the same names as the previous attempts, and all copies stay in the run. download-artifact then picks the one with the highest artifact ID, which is not always the newest: a re-run could test a stale core package (e.g. missing a variant) or merge stale test reports. Set 'overwrite: true' on all uploads in package_core and package_tool, so that each name maps to a single artifact, the one from the latest attempt that produced it. Set 'name' to match the uploaded file name for archive:false uploads. In the case of the board binaries, apply the 'failed-' prefix to the tarball itself before uploading, so that the name matches the file. Reorder all upload flags to 'archive', 'overwrite', 'retention-days'. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pillo79
force-pushed
the
ci-report-attempts
branch
from
October 20, 2026 12:23
65690de to
571e481
Compare
pennam
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few issues in the CI report generation when the test reports are empty. Spotted on a CI run that had 5 attempts.
Most importantly, overwrite every artifact instead of just adding copies, because
action/download-artifactgets the highest-numbered ID if several names match, and the IDs are not monotonic. Old copies may win over the latest one when kept, and that was the real reason the above 5-retry CI run crashed.