Repository navigation
Fix GPT GTCR.TPCS bit position and mask in device headers - #557
Open
JoelRamireddy wants to merge 1 commit into
Open
JoelRamireddy wants to merge 1 commit into
JoelRamireddy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354
In the CMSIS device headers for 10 RA chips,
GTCR.TPCS(Timer Prescaler Select) is defined at the wrong bit position with the wrong width.Current definition:
The RA4M1 User's Manual, section 22.2.12 (General PWM Timer Control Register), shows
TPCS[2:0]as a 3-bit field at b26 to b24, with b23 to b19 reserved. The current definition is off by one and 4 bits wide, so the mask also covers reserved bit 23.Fixed definition:
This matches the Renesas FSP headers (v6.6.0) for each of these chips.
Devices changed (all had
23/0x7800000before, and now match FSP v6.6.0 with24/0x7000000):Each board under
variants/carries its own copy of the FSP include tree, so the same headers exist in every variant. 10 headers x 7 variants (MINIMA,MUXTO,NANOR4,OPTA_ANALOG,OPTA_DIGITAL,PORTENTA_C33,UNOWIFIR4) = 70 files. Each file gets the same two-line change, 140 lines in total. Nothing else is touched, and the variant trees are not deduplicated.