Repository navigation
fix(mcp): scale inline SVG icons to their requested size - #32
Merged
Merged
Conversation
Selectively ports michaelshimeles/sketch PR17 (e904686). HTML parsing lowercases root SVG attributes; restore their SVG case before usvg imports them. The 48-unit icon at 18px regression fails before the change and passes afterwards. No UI or transaction changes. Co-authored-by: DavidEscobar2707 <davidsub2100@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An inline SVG imported through
write_htmlcould draw at its viewBox size rather than its requested pixel size. For example, a 48-unit icon requested at 18px produced a 48px shape inside an 18px frame. Restore the SVG root attribute case after HTML parsing, so the existing importer scales it correctly.Selectively ports michaelshimeles#17, commit
e9046867d6ad393a6c8826249989a764aeb14a77, retaining contributor credit. The patch preserves the existing native UI, transaction, save and host lifecycle behavior.Validation: the regression failed at 48px before the fix and passes at 18px afterwards. Local checks on the main-based patch passed all 13 MCP tests and Clippy; the integrated custom-UI candidate also passed 14 MCP tests, 232 native tests, 9 required GPU checks and the WASM core check. Earlier mixed-compiler and extra adapter-run diagnostics are retained and are not counted as passing acceptance.
All checks passed on final head
5ab3d2c1935dd4b936d36bd38a13c879bb7f6e60: product-site, native, WASM core, and desktop packaging for macOS universal, Windows x64 and Linux x64. The packaging workflow also runs the publication and release-manifest regression tests on each OS. CI package artifacts remain previews; this PR does not publish a public app release or qualify Apple notarization.