Skip to content

Scope generated files during reviews - #29

Merged
gustavonline merged 1 commit into
mainfrom
feat/review-artifact-scope
Oct 12, 2026
Merged

gustavonline merged 1 commit into
mainfrom
feat/review-artifact-scope

Conversation

@gustavonline

@gustavonline gustavonline commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Reviewers were sometimes told to change no files while being asked to run builds or tests that generate files. AgentOps now specifies permitted check outputs and scratch space; Review preserves product sources and holds unsafe or unauthorized cleanup.

For example, a source-only review holds a staging command. A review authorized to use a fresh task-owned directory can run that same command and verify the output.

Validation: independent Astra review PASS; both affected bundles staged and verified with all 45 source files unchanged. Package checker: 8 skills, 0 errors. CI verifies the unit suite before merge.

Evidence and boundaries
  • Opus 5.5 Medium implementation: 2dcdb293b47c633df387d89da018be0e39398e4a. Full-index patch SHA256: 5b04ad0c708a09d42a77b92e0826c87de6029d968389745c030b325d14fb65bc; matches the frozen independent review exactly.
  • Source-only exercise: reviewer inspected the staging script and held its write operation, identifying missing evidence and the bounded handoff. This was an instruction decision, not an OS-denial test.
  • Authorized-output exercise: both stage commands actually returned 0. All 17 staged files, manifests, licenses and local links matched. No installation or deletion.
  • Cleanup exercise: shared/unknown-owner, active and previously refused targets were each held. No destructive operation was attempted.
  • Native commit approval was accepted once; an already-aborted check was declined without replay. Both requests are resolved, the commit exists and the worktree is clean. The writer then hit its provider quota.
  • Four files only; no access, model defaults, runtime or Foundation changes. The originating application incident remains operator-reported. The five unchecked acceptance criteria in issue Prove Agent Ops across idea research, assignments and accepted backlog #3 remain unproved. Unattended operation, installation and native reload are separate checks.

Distinguish source-only review from review with executable checks in the
AgentOps delegation guidance, and state in Review which generated task
artifacts and cleanup are permitted, what must be held and that task prose
is not technical isolation. Record the operator-attributed trigger with
behavioral evidence and independent review left to the delivery PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gustavonline
gustavonline merged commit 817604f into main Oct 12, 2026
1 check passed
@gustavonline
gustavonline deleted the feat/review-artifact-scope branch October 12, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant