-
-
Notifications
You must be signed in to change notification settings - Fork 738
Add optional "Additional fonts" selection to Applications menu #4420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5d34dce
Add Fonts application with multi-select for emoji and CJK packages
Softer e8c66c8
Rename to Additional fonts and add package descriptions
Softer 65ef220
Add noto-fonts to font package selection
Softer c1da056
Move font descriptions into FontPackage enum method
Softer 4e4dbd7
ci: trigger tests
Softer 8c23a8d
Add ttf-liberation and ttf-dejavu to font selection
Softer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| from typing import TYPE_CHECKING | ||
|
|
||
| from archinstall.lib.models.application import FontsConfiguration | ||
| from archinstall.lib.output import debug | ||
|
|
||
| if TYPE_CHECKING: | ||
| from archinstall.lib.installer import Installer | ||
|
|
||
|
|
||
| class FontsApp: | ||
| def install(self, install_session: Installer, fonts_config: FontsConfiguration) -> None: | ||
| packages = [f.value for f in fonts_config.fonts] | ||
| debug(f'Installing fonts: {packages}') | ||
| install_session.add_additional_packages(packages) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this into the
FontPackageitself I think that will make this more readable with aand then
there is also a helper function
but that won't handle the custom description part, so we could enhance that with
or something along those lines