Fix SCE mask shape on early exits - #700
Open
SarveshaKumarKS wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
SarveshaKumarKS
marked this pull request as ready for review
July 30, 2026 01:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
k == 0, and the merge-level output shapeRoot cause
The normal
sce_maskpath builds its mask from the variance tensor, whose shape excludes the leading model dimension. The early exits instead usedzeros_like(tvs)orones_like(tvs), retaining that dimension.sce_mergethen unsqueezed the mask, and PyTorch broadcasting silently introduced an extra leading dimension into the merged tensor.Impact
Degenerate
select_topkvalues such as0, as well as small positive values that round down tok == 0, now return the unchanged base tensor with its original rank instead of a rank-corrupted tensor.Validation
python -m pytest tests/ -q— 94 passedpython -m pytest tests/test_sce.py -q— 6 passedpython -m pytest tests/test_basic_merges.py::TestBasicMerges::test_sce_merge -q— 1 passedpre-commit run --files mergekit/merge_methods/sce.py tests/test_sce.py— all hooks passed