Skip to content

Feature/biometrics - #30

Open
TobiCrackIT wants to merge 28 commits into
developfrom
feature/biometrics
Open

Feature/biometrics#30
TobiCrackIT wants to merge 28 commits into
developfrom
feature/biometrics

Conversation

@TobiCrackIT

Copy link
Copy Markdown
Collaborator
  • Authentication with PIN ans biometrics

@TobiCrackIT
TobiCrackIT requested a review from scotopic October 5, 2021 09:43
- hide biometric option for devices without biometric feature
@scotopic

scotopic commented Oct 5, 2021

Copy link
Copy Markdown
Collaborator

@TobiCrackIT - add a list of URLs where you got the icons

@scotopic scotopic mentioned this pull request Oct 8, 2021
…ng-Initiative/arbor-wallet into biometrics

� Conflicts:
�	lib/core/providers/auth_provider.dart
�	lib/main.dart
�	lib/views/screens/settings/set_pin_screen.dart
�	lib/views/screens/settings/settings_screen.dart
�	lib/views/screens/settings/unlock_with_pin_screen.dart
�	lib/views/widgets/arbor_switch.dart
�	lib/views/widgets/keypad/arbor_keypad.dart
�	lib/views/widgets/pin/pin_indicator.dart
�	pubspec.yaml
@TobiCrackIT

Copy link
Copy Markdown
Collaborator Author

@scotopic, this PR has been updated to make the biometrics feature work as required.

@scotopic

scotopic commented Dec 1, 2021

Copy link
Copy Markdown
Collaborator

Android bug

  1. Install app from scratch
  2. Create a new wallet
  3. Click settings > Enter pin
  4. Background the app
  5. Foreground the app ( see the pin entry screen )
  • EXPECTED: No back button is visible
  • ACTUAL: Back button visible and takes you to the Secret Phrase view

@scotopic

scotopic commented Dec 1, 2021

Copy link
Copy Markdown
Collaborator

iOS bug

  1. Settings > Enable "Unlock with biometrics"
  2. Once the auth view comes up > click Cancel
  • ACTUAL: Another view appears to be added on the stack. Can never cancel out to enter the PIN.
  • EXPECTED: Cancel should remove the biometrics dialog and allow access to the PIN UI

@scotopic

scotopic commented Dec 1, 2021

Copy link
Copy Markdown
Collaborator

iOS issue:

  1. Settings > Enable "Unlock with biometrics"
  2. Tap on "Unlock with biometrics" to disable and authenticate the biometrics.
  • EXPECTED: Biometrics is disabled once the user is authenticated.
  • ACTUAL: PIN UI is shown even after the biometrics is authenticated.

@TobiCrackIT

Copy link
Copy Markdown
Collaborator Author

@scotopic , the issues raised have been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants