fix: address validation and contributors page boundary fixes - #1949
Closed
saurabhhhcodes wants to merge 1 commit into
Closed
fix: address validation and contributors page boundary fixes#1949saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
… in contributors.js - payment.js: clear custom validity on valid address instead of leaving error message - contributors.js: guard pageNo mutation before fetch so prev on page 1 doesn't corrupt state
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixed
1. Address validation always shows error (payment.js)
validateAddress()set a custom validity error message ("Please enter your shipping address.") even when the address was valid. SincecheckValidity()considerssetCustomValidity()messages, the form could never be submitted even with a correctly filled address field.Fix: Clear custom validity with empty string when the address is valid.
2. Contributors page navigation state corruption (contributors.js)
pageNo += pagewas executed before the boundary check. Pressing "prev" on page 1 setpageNoto 0 internally even though the fetch was rejected and the display was not updated. Subsequent "next" clicks restored page 1 instead of advancing to page 2.Fix: Compute the new page value first, guard against negative values, and only mutate
pageNoif the new page is valid.