Stop the agent before removing runner directories - #1628
Merged
Merged
Conversation
The integration runner deletes its per-run working directory as soon as the script exits, but the agent the script started is a separate process that is still running and writes a push payload into that directory shortly after. When the write lands during the delete, `FileUtils.remove_entry` raises `Errno::ENOTEMPTY` and the spec fails, which the collector mode fork spec hits intermittently. When it lands after, the agent recreates the directory and it is left behind. Kill the agent named in `agent.lock` and wait for it to exit before removing the directory. [skip changeset]
|
鉁旓笍 All good! |
unflxw
added
dev happiness
unflxw
marked this pull request as ready for review
September 30, 2026 10:29
bjacquet
approved these changes
Oct 1, 2026
tombruijn
approved these changes
Oct 1, 2026
lipskis
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a CI flaky test, such as this example on
main: https://github.com/appsignal/appsignal-ruby/actions/runs/36077119086/job/107891105176The integration runner deletes its per-run working directory as soon
as the script exits, but the agent the script started is a separate
process that is still running and writes a push payload into that
directory shortly after. When the write lands during the delete,
FileUtils.remove_entryraisesErrno::ENOTEMPTYand the spec fails,which the collector mode fork spec hits intermittently. When it lands
after, the agent recreates the directory and it is left behind. Kill
the agent named in
agent.lockand wait for it to exit before removingthe directory.
[skip changeset]