Repository navigation
Conversation
Options are configured on one thread and read by the handshake on another, so a client holding `SwiftTLSOptions` in a `Sendable` type needs them to be `Sendable`. Every field already is, except the opaque-key signing callback, which the handshake invokes from its own context. * Made `SwiftTLSRefKeySignCallback` `@Sendable`. * Declared `Sendable` on `SwiftTLSOptions`, `SwiftTLSPrivateKey` and `SwiftTLSOpaqueReferenceKey`, along with the nested option types. * Captured the signing keys in the test callbacks rather than `self`.
rnro
requested review from
agnosticdev,
baumanl,
ekinnear,
kpodosin and
tfpauly
as code owners
October 5, 2026 16:41
kpodosin
approved these changes
Oct 5, 2026
tfpauly
approved these changes
Oct 5, 2026
rnro
added
⚠️ semver/major
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options are configured on one thread and read by the handshake on another, so a client holding
SwiftTLSOptionsin aSendabletype needs them to beSendable. Every field already is, except the opaque-key signing callback, which the handshake invokes from its own context.SwiftTLSRefKeySignCallback@Sendable.SendableonSwiftTLSOptions,SwiftTLSPrivateKeyandSwiftTLSOpaqueReferenceKey, along with the nested option types.self.This will be an SPI-breaking change, SemVer major.