Repository navigation
Add Android support - #23
finagolfin wants to merge 1 commit into
Conversation
| #endif | ||
| #if canImport(SwiftTLS) && (os(Linux) || !canImport(CryptoKitPrivate)) | ||
| // For importing the SwiftTLS package on the public SDK or on Linux | ||
| #if canImport(SwiftTLS) && !canImport(CryptoKitPrivate) |
There was a problem hiding this comment.
CryptoKitPrivate is unavailable on non-Darwin, so this check suffices outside Darwin?
| ] | ||
|
|
||
| #if os(Linux) | ||
| #if os(Linux) || os(Android) |
There was a problem hiding this comment.
Considered !os(anyAppleOS) instead, but that won't work on 6.3, which still appears to be supported here.
| #if os(Linux) | ||
| import Crypto | ||
| #else | ||
| #if canImport(CryptoKit) |
There was a problem hiding this comment.
Why is the order of imports changed here?
There was a problem hiding this comment.
No reason, just followed the order used in other files in this repo.
|
@agnosticdev, simple pull, please review. |
|
@tfpauly, this passed CI weeks ago, mind reviewing? |
With these minor tweaks, I was able to build and run all the tests natively on Android against API 24 with a Sep. 21 trunk snapshot toolchain.
| enable_windows_checks: false | ||
| enable_android_sdk_build: false | ||
| enable_embedded_wasm_sdk_build: false | ||
| enable_linux_static_sdk_build: false |
There was a problem hiding this comment.
These SDKs are not built by default so removed them, the converse for linux above.
| macos_exclude_xcode_versions: "[{\"xcode_version\": \"swift_6.1\"}, {\"xcode_version\": \"swift_6.2\"}]" | ||
| enable_linux_checks: true | ||
| linux_swift_versions: '["nightly-main", "nightly-6.3"]' | ||
| linux_exclude_swift_versions: '[{"swift_version": "6.4"}]' |
There was a problem hiding this comment.
Easier to just exclude the latest release, if that is what's wanted going forward too
|
Rebased and cleaned up the CI workflow, including bumping to the latest tag, verified again by building and testing this repo natively on my Android phone in the Termux app |
2 participants
With these minor tweaks, I was able to build and run all the tests natively on Android against API 24 with a Sep. 21 trunk snapshot toolchain.