Repository navigation
Add deinit to SwiftTLSHandshakeAndRecordManager for release linkage - #21
Merged
Merged
Conversation
kpodosin
requested review from
agnosticdev,
baumanl,
ekinnear and
tfpauly
as code owners
September 24, 2026 17:43
tfpauly
approved these changes
Sep 24, 2026
FranzBusch
reviewed
Sep 25, 2026
Comment on lines
+786
to
+787
| // Keeps destruction in-module; without it, optimized clients fail to link. | ||
| deinit {} |
Member
There was a problem hiding this comment.
Is there a swiftlang issue for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftTLSHandshakeAndRecordManager is a public ~Copyable struct whose storage is all internal types (TLSRecordHandler, TLSRecordProtector, TLSHandshakeStateMachine, EncryptionLevel). Without a deinit, an optimized client destroys it member-wise and references those types' metadata accessors, which have hidden linkage. SwiftNetwork failed to link in release with undefined symbols. Declaring one keeps destruction in module.