Skip to content

Fix testQUICEcho1MiBAckBundling build after the handler became `Sen… #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnro merged 1 commit into from
Oct 6, 2026
Merged

Fix testQUICEcho1MiBAckBundling build after the handler became `Sen… #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Tests/SwiftNetworkTests/SwiftNetworkQUICHarnessTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,11 +572,11 @@ final class SwiftNetworkQUICHarnessTests: NetTestCase {
// ACKs should be bundled on outgoing STREAM frames rather than going out in their own
// packet as much as possible, this test tracks that.
func testQUICEcho1MiBAckBundling() {
var packetSizes: [Int] = []
let observedPacketSizes = Mutex<[Int]>([])
let observeFrameHandler: BridgeObserveFrameHandler = { firstByte, byteCount in
// Identify short header packet to accumulate the total sizes at the end
guard (firstByte & 0xC0) == 0x40 else { return }
packetSizes.append(byteCount)
observedPacketSizes.withLock { $0.append(byteCount) }
}

QUICTestHarness().runQUICTest(
Expand All @@ -585,6 +585,7 @@ final class SwiftNetworkQUICHarnessTests: NetTestCase {
bridgeObserveFrameHandler: observeFrameHandler
)

let packetSizes = observedPacketSizes.withLock { $0 }
XCTAssertFalse(packetSizes.isEmpty, "packetSizes should not be empty")

// A standalone ACK (no STREAM data) fits comfortably under 100 bytes, but a
Expand Down
Loading