Repository navigation
Throw instead of truncating in the HTTP body collect(into:) - #195
Merged
Merged
Conversation
`collect(into:)` for HTTP body readers dropped the bytes beyond the buffer's free capacity, and stopped reading once the buffer was full, so a body longer than the buffer looked like a complete body without trailers, and a body exactly as long as the buffer lost its trailers. It now appends the bytes that fit and throws `AsyncReaderLeftOverElementsError` (in an `EitherError`, as AsyncStreaming's `collect(into:)` does) for a longer body, and keeps reading a full buffer until the end of the body, so a body that fits exactly returns its trailers.
FranzBusch
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect(into:)for HTTP body readers dropped the bytes beyond the buffer's free capacity, and stopped reading once the buffer was full, so a body longer than the buffer looked like a complete body without trailers, and a body exactly as long as the buffer lost its trailers.It now appends the bytes that fit and throws
AsyncReaderLeftOverElementsError(in anEitherError, as AsyncStreaming'scollect(into:)does) for a longer body, and keeps reading a full buffer until the end of the body, so a body that fits exactly returns its trailers.