Repository navigation
Enable swift-collections' UnstableContainersPreview trait and pin it to 1.6.0 - #191
Merged
FranzBusch merged 1 commit intoSep 29, 2026
Conversation
inductor
force-pushed
the
enable-unstable-containers-preview-trait
branch
from
September 29, 2026 06:57
0f528ba to
ab819a1
Compare
inductor
changed the title
Contributor
|
Did you try with 1.7.1 or is the pinning still needed even with it? https://github.com/apple/swift-collections/releases/tag/1.7.1 |
Collaborator
|
Let's bump the async-algos version since this was fixed: apple/swift-async-algorithms#456 |
FranzBusch
approved these changes
Sep 29, 2026
FranzBusch
left a comment
FranzBusch
left a comment
Member
There was a problem hiding this comment.
Thanks. That will keep this more stable for now
Member
|
Merging over the failure since that is unrelated and because of something in swift-async-algos |
Member
|
Sorry I just saw your two comments @czechboy0 and @guoye-zhang. @inductor can you do those in a follow up. |
Member
Author
|
I’ll make a new PR! |
Member
Author
|
@czechboy0 Yes, I tried 1.7.1 but didn't work as expected on this configuration. |
Member
Author
|
Let's try to update swift-collections to 1.7.x after apple/swift-async-algorithms#459 |
FranzBusch
pushed a commit
that referenced
this pull request
Oct 5, 2026
…#193) ### Motivation Follow-up to #191. As suggested there, we should move swift-async-algorithms past 1.1.5, which doesn't build against swift-collections 1.7.x (apple/swift-async-algorithms#455). swift-async-algorithms 1.1.6 and later require swift-collections `from: "1.7.0"`, so swift-collections has to move too. In swift-collections 1.7.x the container protocols require 27.0 on Apple platforms (`SwiftStdlib 6.4`). With swift-async-algorithms 1.1.6 that breaks the AsyncStreaming build on Apple platforms, and 1.1.7 (apple/swift-async-algorithms#459) fixes it by raising AsyncStreaming's availability to 27.0. Since `HTTPAPIs` is built on AsyncStreaming, its availability has to be raised to 27.0 as well. ### Modifications - Raised every `@available(anyAppleOS 26.0, *)` in Sources, Tests and Examples to `@available(anyAppleOS 27.0, *)`. - Updated swift-collections to `exact: "1.7.1"` and swift-async-algorithms to `exact: "1.1.7"`. Both stay pinned with `exact` since their unstable traits can change in any release. - Re-exported `SpanPreview` from `HTTPAPIs` alongside `ContainersPreview`, since swift-collections 1.7 moved `span` into `SpanPreview`. - Updated the swift-http-server submodule to include swift-server/swift-http-server#143, which raises its availability to 27.0 in the same way. ### Result The package builds against swift-collections 1.7.1 and swift-async-algorithms 1.1.7. All APIs now require 27.0 on Apple platforms. ### Test Plan Builds and tests pass on macOS and on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
HTTPAPIsimportsContainersPreviewand uses its container protocols, which need swift-collections'UnstableContainersPreviewtrait. This package doesn't enable the trait itself. It only builds because swift-async-algorithms enables it indirectly, and that has been failing for some consumers.Also, swift-collections isn't pinned (
from: "1.6.0"), so CI resolves 1.7.x, where swift-async-algorithms 1.1.5 fails to build (value of type 'UniqueDeque<Element>?' has no member 'borrow'). main has been failing for this reason since 1.7.0.Modifications
Enable the
UnstableContainersPreviewtrait on swift-collections and pin it withexact: "1.6.0". Like swift-async-algorithms and async-http-client, it now uses an unstable trait whose API can change in any release.Result
The package declares the trait it relies on, and CI builds again.
Test Plan
Builds and tests pass on Linux with Swift 6.4.