Repository navigation
Add a SWIFT_CONFIGURATION_EXTRA hook for extra swift build flags - #2354
Merged
Merged
Conversation
SWIFT_CONFIGURATION is a := assignment carrying -warnings-as-errors and -enable-testing, so a caller wanting to add a flag had to override the whole variable and thereby drop those. Append an overridable SWIFT_CONFIGURATION_EXTRA instead, so extra flags compose with the existing configuration rather than replacing it. Empty by default, so this is a no-op unless set.
katiewasnothere
approved these changes
Oct 6, 2026
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
SWIFT_CONFIGURATION is a := assignment carrying -warnings-as-errors and -enable-testing, so a caller wanting to add a flag had to override the whole variable and thereby drop those. Append an overridable SWIFT_CONFIGURATION_EXTRA instead, so extra flags compose with the existing configuration rather than replacing it.
Empty by default, so this is a no-op unless set.
Testing