Skip to content

FEAT: Integrate DORA compliance to CLI pipeline - #68

Open
Yibaebi wants to merge 1 commit into
developfrom
PD-2357-dora-compliance-integration
Open

FEAT: Integrate DORA compliance to CLI pipeline#68
Yibaebi wants to merge 1 commit into
developfrom
PD-2357-dora-compliance-integration

Conversation

@Yibaebi

@Yibaebi Yibaebi commented Aug 12, 2026

Copy link
Copy Markdown
Title Value
Type Feature
Ticket/Issue PD-2422
Migrations No
Migration Scripts No
ENV vars change No
Frontend No
Local testing Done
Staging testing Pending
On premise notes See below
Documentation DORA Compliance
Release notes None
Version upgrade Minor

Changelog

Surfaces DORA compliance codes in the appknox analyses <file-id> output, mirroring how SAMA and NIST are already handled. Backend support already exists in mycroft — this is a CLI-only change.

  1. Add Dora to the Analysis struct, so the dora field returned by api/v2/files/{id}/analyses is decoded instead of dropped.

    Sama            []string `json:"sama,omitempty"`
    Dora            []string `json:"dora,omitempty"`
    Owaspmobile2024 []string `json:"owaspmobile2024,omitempty"`
  2. Add ShowDora to ProjectProfileReportPreference, read from api/profiles/{id}/report_preference.

    ShowSama RegulatoryPreference `json:"show_sama,omitempty"`
    ShowDora RegulatoryPreference `json:"show_dora,omitempty"`
  3. Modify the analyses table in helper/analyses.go to render a DORA column, gated on the profile preference and placed immediately after SAMA. When show_dora is off the output is byte-for-byte unchanged.

    if profileReportPref.ShowDora.Value {
        header = append(header, "DORA")
    }
    ...
    if profileReportPref.ShowDora.Value {
        row = append(row, finalAnalyses[i].Dora)
    }
  4. Add test coverage:

    • dora in the Analysis marshal round-trip
    • TestAnalysesService_ListByFile_Compliance — new; asserts the server→struct decode off the analyses endpoint, the direction that catches a wrong JSON tag (the marshal test alone would still pass)
    • show_dora added to the report-preference marshal test and to the mocked GET report_preference response

@Yibaebi Yibaebi changed the title feat: integrate DORA compliance to CLI pipeline FEAT: Integrate DORA compliance to CLI pipeline Aug 12, 2026
@sonarqubecloud

Copy link
Copy Markdown

@avraichur96
avraichur96 self-requested a review August 13, 2026 06:04

@avraichur96 avraichur96 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants