Repository navigation
fix: retain benchmark outcomes with measurement warnings - #3683
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A successful benchmark can be discarded because its build is slow, cache counters are missing, or diagnosis token usage is unavailable. Filtering those runs hides regressions and confuses missing telemetry with a failed task. Fixes #3679.
Solution
Keep proven outcomes valid and expose measurement warnings in run records, reports, and the viewer. Unknown timings and diagnosis costs remain unknown. Timeouts, device identity, evidence hashes, visual proof, source repair, and capture-before-source checks remain validity requirements.
Benign setup warnings now publish after evidence checks pass; source/evidence corrections and auxiliary sessions still require review. This deliberately changes the abnormal-build timing gate from #435 to retain regressions, and narrows #513's setup-review requirement. Historical rejected records are not silently rewritten.
Test plan