Skip to content

mobile: PixelDismiss grid may leave an app strip on Android 3-button navigation #1795

Closed

Description

@janicduplessis

Problem

PixelDismiss (#1763) sizes its grid from useWindowDimensions() and no longer adds the extra margin rows #1714 had. On Android with 3-button navigation, or in split screen, the window can differ from the overlay's real size, so a strip of the app could show at the top or bottom on the splash's first frame. Only gesture navigation was checked, where the bars stayed purple. The reviewer left this note open on #1763.

Expected

The purple grid covers the whole overlay on every navigation mode. For example, size it from the overlay's own layout, or add a margin row on each edge. Verify on an Android emulator with 3-button navigation.

Activity

  1. janicduplessis commented on Sep 28, 2026

    @janicduplessis
    CollaboratorAuthor

    Claimed: fix/1795-pixel-dismiss-grid

  2. janicduplessis commented on Sep 28, 2026

    @janicduplessis
    CollaboratorAuthor

    Root cause is not the grid size. On a 1080x2400 API 36 emulator with 3-button navigation, window, screen and the overlay's onLayout all measure 411.4 x 914.3 dp, and the grid is 987 dp tall, so it covers the whole overlay. The lavender strip is Android's navigation bar contrast scrim: React Native's edge-to-edge leaves contrast enforcement on unless the theme turns it off, and Android draws that scrim only behind 3-button navigation. Every recorded pixel inside the navigationBars inset frame was (235,230,252), splash purple under a white scrim. The fix in #1836 turns off the scrim in the app theme. It is a native change, so it ships with the next binary build, not by OTA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions