Skip to content

fix: bump BrowserPool default operation_timeout to 60 seconds#1877

Merged
vdusek merged 1 commit intomasterfrom
fix/browser-pool-default-operation-timeout
May 7, 2026
Merged

fix: bump BrowserPool default operation_timeout to 60 seconds#1877
vdusek merged 1 commit intomasterfrom
fix/browser-pool-default-operation-timeout

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented May 6, 2026

Summary

The previous 15s default of BrowserPool.operation_timeout was too tight for chromium cold-start on slow runners. Windows CI with Python 3.14 has been flaking out with:

TimeoutError: Creating a new page with plugin <PlaywrightBrowserPlugin ...> timed out.

Bumping the default to 60s gives chromium enough headroom on slow machines without changing behavior for users who already pass an explicit operation_timeout. Same value used in the existing precedent fix for test_with_default_plugin_constructor (PR #1806).

Failing CI run: https://github.com/apify/crawlee-python/actions/runs/25332581547/job/74269691220?pr=1869

The previous 15s default was too tight for chromium cold-start on slow
runners (Windows CI with Python 3.14 has been flaking out), causing
spurious `TimeoutError: Creating a new page with plugin ... timed out.`
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels May 6, 2026
@vdusek vdusek self-assigned this May 6, 2026
@github-actions github-actions Bot added this to the 140th sprint - Tooling team milestone May 6, 2026
@vdusek vdusek requested a review from janbuchar May 6, 2026 09:07
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.53%. Comparing base (65bf68d) to head (1583ce3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1877      +/-   ##
==========================================
- Coverage   92.57%   92.53%   -0.04%     
==========================================
  Files         158      158              
  Lines       11078    11078              
==========================================
- Hits        10255    10251       -4     
- Misses        823      827       +4     
Flag Coverage Δ
unit 92.53% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 38e7dd2 into master May 7, 2026
32 checks passed
@vdusek vdusek deleted the fix/browser-pool-default-operation-timeout branch May 7, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants