chore: Bump ty to v0.0.14 and fix type issues#1696
Merged
vdusek merged 1 commit intoapify:masterfrom Jan 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project's compatibility with ty v0.0.14, a Python type checker. The update primarily involves updating the dependency version and making adjustments to code to address type checking issues that have been fixed or newly detected by the updated version.
Changes:
- Updated
tydependency from v0.0.13 to v0.0.14 in the lock file - Removed a type ignore comment in PlaywrightCrawler that was addressing a false positive now fixed in ty v0.0.14
- Added runtime type checks and type ignore comments where ty v0.0.14 requires them
- Applied
np.asarray()wrapper to sklearn model coefficient serialization for proper type handling
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updates ty dependency from v0.0.13 to v0.0.14 with new wheel URLs and hashes |
| tests/unit/storage_clients/_redis/test_redis_rq_client.py | Adds runtime type assertion and type ignore comment for Redis response handling |
| src/crawlee/storage_clients/_redis/_key_value_store_client.py | Adds runtime type validation for Redis dictionary values before JSON parsing |
| src/crawlee/crawlers/_playwright/_playwright_crawler.py | Removes obsolete type ignore comment for cookie handling (issue fixed in ty v0.0.14) |
| src/crawlee/crawlers/_adaptive_playwright/_utils.py | Wraps sklearn model.coef_ with np.asarray() for proper type checking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vdusek
changed the title
ty v0.0.14
Mantisus
added a commit
to Mantisus/crawlee-python
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.