Skip to content

fix(apps): start zero-replica stopped components - #10814

Merged
leon-ape merged 1 commit into
release-1.0from
bugfix/10813-zero-replica-start
Aug 28, 2026
Merged

fix(apps): start zero-replica stopped components#10814
leon-ape merged 1 commit into
release-1.0from
bugfix/10813-zero-replica-start

Conversation

@leon-ape

Copy link
Copy Markdown
Collaborator

Summary

  • avoid mutating the cached running InstanceSet while clearing the stop replica snapshot
  • explicitly remove the controller-owned snapshot annotation from the outgoing update
  • add regression coverage for starting a workload whose saved replica count is zero

Branch assessment

  • main: unaffected; uses native InstanceSet spec.stop
  • release-1.1: unaffected; uses native InstanceSet spec.stop
  • release-1.0: affected; still uses the stop replica snapshot annotation

Testing

  • focused zero-replica regression test
  • full controllers/apps/component package

Fixes #10813

@leon-ape
leon-ape requested a review from a team as a code owner August 28, 2026 04:05
@github-actions github-actions Bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 28, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.25%. Comparing base (c55a6d5) to head (2c24fb1).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0   #10814      +/-   ##
===============================================
+ Coverage        54.17%   54.25%   +0.07%     
===============================================
  Files              495      495              
  Lines            55939    55945       +6     
===============================================
+ Hits             30305    30353      +48     
+ Misses           22624    22590      -34     
+ Partials          3010     3002       -8     
Flag Coverage Δ
unittests 54.25% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape

Copy link
Copy Markdown
Collaborator Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Aug 28, 2026
@leon-ape leon-ape linked an issue Aug 28, 2026 that may be closed by this pull request
@leon-ape
leon-ape merged commit d75bc56 into release-1.0 Aug 28, 2026
47 of 48 checks passed
@leon-ape
leon-ape deleted the bugfix/10813-zero-replica-start branch August 28, 2026 05:17
@github-actions github-actions Bot added this to the Release 1.2.0 milestone Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 0-Replica component start gets stuck in Starting phase

2 participants