chore: avoid redis create test panic - #695
Merged
Merged
Conversation
ldming
changed the title
ldming
marked this pull request as ready for review
July 14, 2026 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clusterDefoutput instead of indexing an optional component-definition listRoot cause
The Redis create test indexed
ChartInfo.ComponentDef[0]. In CI the list was empty for a valid rendered Redis cluster, causing an index-out-of-range panic. The rendered chart always identifies the cluster throughclusterDef: redis.Validation
go test ./pkg/cmd/cluster -run '^TestCluster$' -count=1 -ginkgo.focus='create sharding cluster command'\n-go test ./... -coverprofile=coverage.txt\n-golangci-lint run --timeout=5m ./pkg/cmd/cluster/...