Skip to content

chore: respect namespace in report cluster - #691

Merged
ldming merged 2 commits into
release-1.0from
support/report-cluster-namespace-release-1.0
Jul 14, 2026
Merged

chore: respect namespace in report cluster#691
ldming merged 2 commits into
release-1.0from
support/report-cluster-namespace-release-1.0

Conversation

@shanshanying

Copy link
Copy Markdown
Contributor

Summary

  • Backport the report cluster namespace fix from PR fix: respect namespace set by user #613 to release-1.0.
  • Preserve the namespace passed by -n/--namespace instead of overwriting it with the current kubeconfig namespace.
  • Add a regression test for the explicit namespace case.

Validation

  • GOCACHE=/private/tmp/kbcli-go-test-cache-release10 go test ./pkg/cmd/report -count=1

@github-actions github-actions Bot added the size/S Denotes a PR that changes 10-29 lines. label Jun 30, 2026
@shanshanying
shanshanying marked this pull request as ready for review June 30, 2026 07:16
@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.93%. Comparing base (b49962c) to head (9276b63).

Files with missing lines Patch % Lines
pkg/cmd/report/report.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0     #691      +/-   ##
===============================================
- Coverage        39.94%   39.93%   -0.01%     
===============================================
  Files              172      172              
  Lines            24026    24027       +1     
===============================================
- Hits              9597     9595       -2     
- Misses           13308    13310       +2     
- Partials          1121     1122       +1     
Flag Coverage Δ
unittests 39.93% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shanshanying
shanshanying force-pushed the support/report-cluster-namespace-release-1.0 branch from c50c81e to 9276b63 Compare June 30, 2026 08:00
@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jun 30, 2026
@ldming
ldming merged commit 0fe7133 into release-1.0 Jul 14, 2026
12 checks passed
@ldming
ldming deleted the support/report-cluster-namespace-release-1.0 branch July 14, 2026 02:51
@github-actions github-actions Bot added this to the Release 1.0 milestone Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants