[FEAT] Add Expected<void> specialization#673
Merged
Merged
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Kathryn-cat
force-pushed
the
kathrync/expected-void
branch
from
July 16, 2026 22:55
2a75c56 to
d405f5d
Compare
tqchen
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Expected for operations that can succeed without returning a value. Success uses the canonical FFI None representation, while failures retain ffi::Error.
It extends ExpectedUnsafe and TypeTraits for Expected, adds Function::CallExpected support with result validation, and includes tests covering construction, access, FFI conversion, error propagation, and typed function integration.