Skip to content

fix(packaging): tag core wheels per-version instead of abi3#672

Merged
tqchen merged 2 commits into
apache:mainfrom
cyx-6:fix-abi3-wheel-tag
Jul 16, 2026
Merged

fix(packaging): tag core wheels per-version instead of abi3#672
tqchen merged 2 commits into
apache:mainfrom
cyx-6:fix-abi3-wheel-tag

Conversation

@cyx-6

@cyx-6 cyx-6 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Fixes the mainline-only CI, failing on every push to main since #593. Two one-line changes in pyproject.toml:

1. Wheel tag#593 moved core off abi3 to the per-version C API (WITH_SOABI) but left wheel.py-api = "cp312", so wheels were still tagged cp312-abi3. abi3audit --strict rejected them (27 non-limited-API symbols). Dropped the stale setting so wheels tag per-version.

2. cp313 aarch64 test — with the audit fixed, the test phase ran and hit a second issue: torch ships no cp313 aarch64 wheel for manylinux2014 (manylinux_2_17), so its test install is unsatisfiable. Added cp313-*aarch64 to test-skip (cp313 x86_64 and cp313 aarch64 on manylinux_2_28 still tested).

Verified green across the full mainline-only wheel matrix (all 6 build jobs + clang-tidy) via a temporary PR trigger, now removed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates pyproject.toml by removing the wheel.py-api = "cp312" configuration and adding a comment explaining that wheels must be tagged per-version (e.g., cp312-cp312) rather than using the limited API (abi3), as the core extension builds against the full per-version Python C API. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cyx-6
cyx-6 force-pushed the fix-abi3-wheel-tag branch from 731aaca to cf0432f Compare July 16, 2026 08:27
@tqchen
tqchen merged commit 21e30c3 into apache:main Jul 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants