fix(packaging): tag core wheels per-version instead of abi3#672
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates pyproject.toml by removing the wheel.py-api = "cp312" configuration and adding a comment explaining that wheels must be tagged per-version (e.g., cp312-cp312) rather than using the limited API (abi3), as the core extension builds against the full per-version Python C API. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
cyx-6
force-pushed
the
fix-abi3-wheel-tag
branch
from
July 16, 2026 08:27
731aaca to
cf0432f
Compare
tqchen
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
mainline-onlyCI, failing on every push tomainsince #593. Two one-line changes inpyproject.toml:1. Wheel tag — #593 moved
coreoff abi3 to the per-version C API (WITH_SOABI) but leftwheel.py-api = "cp312", so wheels were still taggedcp312-abi3.abi3audit --strictrejected them (27 non-limited-API symbols). Dropped the stale setting so wheels tag per-version.2. cp313 aarch64 test — with the audit fixed, the test phase ran and hit a second issue: torch ships no cp313 aarch64 wheel for
manylinux2014(manylinux_2_17), so its test install is unsatisfiable. Addedcp313-*aarch64totest-skip(cp313 x86_64 and cp313 aarch64 onmanylinux_2_28still tested).Verified green across the full
mainline-onlywheel matrix (all 6 build jobs + clang-tidy) via a temporary PR trigger, now removed.