#1532 - add key sync from SVN - #1535
Merged
Merged
Conversation
alitheg
force-pushed
the
key_import_from_svn
branch
from
August 27, 2026 13:25
7f98ff1 to
dbf15cc
Compare
sbp
requested changes
Aug 27, 2026
sbp
left a comment
sbp
left a comment
Contributor
There was a problem hiding this comment.
Could this do a sync when (a) the reflect mode is first selected for older committees, or (b) when a new committee is detected in reflect mode? The first is less likely to be a problem because I only recently did the backfill, but I expect the latter might be confusing as the net effect is that nothing gets imported until the next KEYS change.
There are also a couple of "you can't edit this" methods on ATR that haven't been blocked in refusal mode: you can change which committees your own keys are linked to, and you can also delete your own key.
Otherwise, looks good!
Contributor
Author
|
Great ideas and good catch on the refusals (or lack of). Will sort these and wrap it up. |
alitheg
force-pushed
the
key_import_from_svn
branch
2 times, most recently
from
August 28, 2026 10:05
1a351d6 to
939a48b
Compare
alitheg
force-pushed
the
key_import_from_svn
branch
from
August 28, 2026 10:12
939a48b to
439cb48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add key sync from SVN and update the mode selection UI to include this. Because we decided keys shouldn't be removable once used, I also added a flag to keys removed from SVN but still in use.