Skip to content

Alert Banner for asset links - #4717

Merged
tenthe merged 14 commits into
devfrom
4716-add-loading-banner-for-asset-links
Jul 23, 2026
Merged

Alert Banner for asset links #4717
tenthe merged 14 commits into
devfrom
4716-add-loading-banner-for-asset-links

Conversation

@JHoelli

@JHoelli JHoelli commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
image image

@JHoelli JHoelli linked an issue Jul 13, 2026 that may be closed by this pull request
@github-actions github-actions Bot added the ui Anything that affects the UI label Jul 13, 2026
@JHoelli JHoelli changed the title feat (#4616): Alert Banner for asset links Alert Banner for asset links Jul 13, 2026
@JHoelli
JHoelli marked this pull request as ready for review July 13, 2026 06:44
@github-actions github-actions Bot added the documentation Everything related to documentation label Jul 23, 2026

@SvenO3 SvenO3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sorting of the asset links by type or name also seems broken because of the loading spinner.
But otherwise it looks good to me

LayoutDirective,
} from '@ngbracket/ngx-layout/flex';
import {
SpAlertBannerComponent,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the import of the SpAlertBannerComponent is still needed for view-asset-links.component.html

@tenthe
tenthe merged commit acf6da1 into dev Jul 23, 2026
23 checks passed
@tenthe
tenthe deleted the 4716-add-loading-banner-for-asset-links branch July 23, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Everything related to documentation ui Anything that affects the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Loading Banner for asset links

3 participants