Repository navigation
SOLR-16396 | Migrate GET config sections query, searchComponent & queryResponseWriter to JAX-RS - #5125
Merged
Conversation
Contributor
Author
Testing for query
|
Contributor
Author
Testing for searchComponent
|
Contributor
Author
Testing for queryResponseWriter
|
jaykay12
commented
Oct 14, 2026
jaykay12
left a comment
jaykay12
left a comment
Contributor
Author
There was a problem hiding this comment.
self-review ✅
local testing ✅
all CI checks passing ✅
…it one is hte query param to path param
Switches GET /config/{component}?componentName= to GET
/config/{component}/{componentName}, matching other v2 API conventions.
Also fixes an NPE-on-unknown-componentName bug (now returns 404), and
deduplicates the filtering logic that was copy-pasted between the new v2
code and the legacy v1 handler. Adds test coverage for all three.
Contributor
|
okay, I poked a bit and I think the new pattern is more "restful"... |
2 similar comments
Contributor
|
okay, I poked a bit and I think the new pattern is more "restful"... |
Contributor
|
okay, I poked a bit and I think the new pattern is more "restful"... |
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16396
Description
Part of SOLR-16396 (Config GET → JAX-RS)
This PR: migrate the three similar-kinds section GETs to JAX-RS:
Already landed / related:
Solution
AI Disclaimer: Used Cursor for Approach formulation, code is fully vetted & reviewed by me.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.