Skip to content

SOLR-16396: Replace the GET /config/{component} wildcards with explicit paths - #5097

Merged
epugh merged 3 commits into
apache:mainfrom
jaykay12:SOLR-16396-config-explcit-paths
Oct 11, 2026
Merged

epugh merged 3 commits into
apache:mainfrom
jaykay12:SOLR-16396-config-explcit-paths

Conversation

@jaykay12

@jaykay12 jaykay12 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-16396

Description

Replace the GET /config/{component} wildcards with explicit paths

Solution

Precursor PR for the ongoing initiative: Config V2 Migrations to JAX-RS.
Reference comment: #5022 (comment)

Used Cursor for Code, Testing & code is fully vetted by @jaykay12

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

@github-actions github-actions Bot added the tests label Oct 10, 2026
@jaykay12

Copy link
Copy Markdown
Contributor Author

/no-changelog

@jaykay12 jaykay12 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epugh
can please trigger workflows on it?
if crave tests pass for this, then this can be independently merged into main.

@epugh epugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Wow, look at all those paths to migrate! Will merge after tests run.

@epugh epugh self-assigned this Oct 10, 2026
@jaykay12

Copy link
Copy Markdown
Contributor Author

@epugh why is changelog workflow failing, even after me getting added the no-changelog label on this PR?

@janhoy

janhoy commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@epugh why is changelog workflow failing, even after me getting added the no-changelog label on this PR?

Because my workflow code assumed that setting a label from a workflow would then trigger the workflow again, but that is not the case, it only triggers when a human sets the label, not when the workflow does it... So the workflow needs fixing.

@epugh

epugh commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Thanks @janhoy for chiming in, and your fix for this....!

@epugh epugh added this to the 10.x milestone Oct 11, 2026
@epugh
epugh merged commit d76fc14 into apache:main Oct 11, 2026
6 of 8 checks passed
@jaykay12
jaykay12 deleted the SOLR-16396-config-explcit-paths branch October 11, 2026 06:48
dsmiley pushed a commit that referenced this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants