Repository navigation
SOLR-5505: LoggingInfoStream not usable in a multi-core setup - #5072
Open
nick-boss-tech wants to merge 3 commits into
Open
nick-boss-tech wants to merge 3 commits into
nick-boss-tech wants to merge 3 commits into
Conversation
nick-boss-tech
marked this pull request as ready for review
October 9, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖 (posted on behalf of Nick Shanin)
https://issues.apache.org/jira/browse/SOLR-5505
What happens today
With
infoStreamon, IndexWriter log lines do not name their core.On main, setting
<infoStream>true</infoStream>creates aLoggingInfoStreamwith no core name (SolrIndexConfig.java). Its lines carry only the component and the thread name (LoggingInfoStream.java).What this change does
Each log line gets the core name as a
[core]segment.When the configured stream is a
LoggingInfoStream, each IndexWriter gets its own copy that knows the core name (SolrIndexConfig.java). A line now reads[core][component][thread]: message(LoggingInfoStream.java). Any otherInfoStreampasses through unchanged.API addition: the public constructor
LoggingInfoStream(String coreName)(LoggingInfoStream.java). The no-argument constructor stays.Behavior change: with infoStream on, every line gains the
[core]segment. Log parsers that match the old format will see the change. No setting keeps the old format.Proof
TestInfoStreamLogging.testMessagesNameTheCorechecks that a logged line names the core.The test is TestInfoStreamLogging.java.
[core][IW]check is the one that fails.d382d9a21e26: TestInfoStreamLogging 2/2, neighbor TestSolrIndexConfig 2/2. The module checks pass.A choice to check
The core name is always on. The other route makes it opt-in.
The other route adds a setting that turns the
[core]segment on. The old format stays the default, and that change's changelog type would beadded. As implemented, there is no setting and the changelog type ischanged.Was an always-on core name the right call, or should an opt-in setting keep the old format by default?
Limits
Two parts are not covered by a test.
Changelog:
changelog/unreleased/SOLR-5505-infostream-core-name.ymlAI assistance
AI agents assisted with research, implementation, review, and drafting. Nick Shanin directed the work and takes responsibility for this contribution.