Skip to content

SOLR-18510: Port AssertTool to picocli - #5036

Merged
janhoy merged 3 commits into
apache:mainfrom
serhiy-bzhezytskyy:SOLR-18510-picocli-assert
Oct 8, 2026
Merged

janhoy merged 3 commits into
apache:mainfrom
serhiy-bzhezytskyy:SOLR-18510-picocli-assert

Conversation

@serhiy-bzhezytskyy

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-18510

Description

Adds the picocli code path for bin/solr assert, next to the commons-cli one. test_auth.bats uses assert to wait for startup, so it could not join the picocli suite until now.

Solution

AssertTool gets its annotated options and callTool() and is registered in SolrCLI; the commons-cli path is unchanged. Written with Claude Code.

Tests

AssertToolPicocliTest runs the existing AssertToolTest through picocli. test_auth.bats passes under both parsers and is added to integrationTestsPicocli; check -x test is clean (rat skipped).

Checklist

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

Adds the picocli code path next to the commons-cli one, with a test twin, the generated reference page and test_auth.bats in the picocli suite.
@github-actions github-actions Bot added documentation Improvements or additions to documentation tool:build tests cat:cli labels Oct 6, 2026

@janhoy janhoy left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No picocli feature has been released yet, so a new command is a detail of the SOLR-17697 entry. Its author and JIRA are added there instead of a separate entry.
@janhoy
janhoy merged commit 34e4757 into apache:main Oct 8, 2026
7 checks passed
@janhoy janhoy added this to the 10.x milestone Oct 8, 2026
dsmiley pushed a commit that referenced this pull request Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:cli documentation Improvements or additions to documentation tests tool:build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants