Remove unnecessary maven.compiler overrides and add CI check#806
Merged
Remove unnecessary maven.compiler overrides and add CI check#806
Conversation
… and add CI check - Remove maven.compiler.release=17 from spring-ai-1.x-plugin (no JDK 17+ language features used) - Remove redundant maven.compiler.source/target=8 from aerospike, jedis, nats, micronaut, tomcat plugins - Add CI script (tools/plugin/check-compiler-overrides.sh) with allowlist to prevent future occurrences - Update CLAUDE.md and new-plugin skill with compiler level guidance
…mpiler.release - Replace Map.of() (JDK 9+) with LinkedHashMap in InputMessages.java - Set <maven.compiler.release /> to cancel parent's --release 8, allowing the compiler to resolve java.lang.Record from provided Spring AI classes - Add spring-ai-1.x-plugin to compiler override allowlist
Distinguish between plugins that require JDK 11/17+ APIs vs plugins that only need API visibility for provided deps using Record types.
…compiler.release Same pattern as jdk-http-plugin: javadoc plugin fails on empty maven.compiler.release value, so set failOnError=false.
peachisai
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven.compiler.release=17fromspring-ai-1.x-plugin— its source code uses no JDK 17+ language features; theprovided-scope dependency on Spring AI doesn't require raising the compiler level.maven.compiler.source/target=8from 6 other plugins (aerospike, jedis, nats, micronaut-http-server, micronaut-http-client, tomcat-10x) since JDK 8 is already the default.tools/plugin/check-compiler-overrides.shCI check with an allowlist to prevent unnecessary compiler overrides in future PRs. Currently allowed:jdk-httpclient-plugin(uses JDK 11 HttpClient API) andjdk-http-plugin(resets to blank).Test plan
check-compiler-overrides.shpasses locally