Console: add kmsUnavailable option for S3 catalogs - #261
Open
yalindogusahin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kmsUnavailablefield (already supported by the Polaris REST API'sAwsStorageConfigInfo, added upstream in (feat) Add support for no KMS with s3-compatible backend polaris#3501 and exposed via the CLI's--no-kmsflag oncatalogs create) to the console'sStorageConfigInfotype, the create/edit catalog forms, the details view, and the checked-in OpenAPI spec.stsUnavailable/pathStyleAccessboolean field pattern already used in both catalog modals.Changes
console/src/types/api.ts: addkmsUnavailable?: booleantoStorageConfigInfoconsole/spec/polaris-management-service.yml: addkmsUnavailabletoAwsStorageConfigInfo, matching the upstream Polaris spec wordingconsole/src/components/forms/CreateCatalogModal.tsx/EditCatalogModal.tsx: add thes3_kmsUnavailableform field, checkbox UI, and payload wiringconsole/src/pages/CatalogDetails.tsx: displayKMS Unavailable: truein the S3 storage config section when setTest plan
npm run lintpasses with no warnings/errorsnpx tsc -b --noEmitpasses with no errors