Add an SSE group-key generator provider - #19385
Draft
xiangfu0 wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19385 +/- ##
============================================
+ Coverage 57.71% 67.58% +9.87%
- Complexity 7 1430 +1423
============================================
Files 2686 3488 +802
Lines 163987 224360 +60373
Branches 26627 35408 +8781
============================================
+ Hits 94640 151637 +56997
+ Misses 61352 60695 -657
- Partials 7995 12028 +4033
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
force-pushed
the
xiangfu0/offheap-sse-provider-seam
branch
from
August 29, 2026 09:07
4b274fd to
98f8ec5
Compare
Downstream Pinot distributions need a narrow extension point to supply specialized group-key generators without replacing the SSE group-by pipeline. Expose immutable physical metadata at executor construction while preserving the default provider identity fast path and built-in selection. Keep filtered aggregations on the shared built-in generator while still allowing plan-level policy validation. Make generator ownership explicit across raw-result transfer, combine, materialization, and partial-construction failures so resource-owning implementations are closed exactly once. The extension remains LimitedPrivate and Unstable, and does not add an implementation or query option.
xiangfu0
force-pushed
the
xiangfu0/offheap-sse-provider-seam
branch
from
August 29, 2026 09:31
98f8ec5 to
148993d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupKeyGeneratorProviderextension point for single-stage group-by planningGroupKeyGeneratorContextThis is an extension seam only. The default provider is an identity sentinel, so existing queries keep the current built-in group-key generators and behavior.
Extension example
Providers return
Optional.empty()for unsupported physical shapes. Every non-empty result must be a fresh, query-owned generator and participates in Pinot's close/ownership-transfer contract. A provider reused across plans or queries must be thread-safe.The plan-maker hook is also called for filtered group-by queries so an override can validate policy. Filtered execution continues to use Pinot's shared built-in generator and ignores the returned provider.
Validation
pinot-coregroup-by/provider/lifecycle testspinot-coreScope
The provider is currently
LimitedPrivate("StarTree")andUnstable. This PR does not add an off-heap implementation or a new query/config option; those live in the dependent StarTree change.