Add V7 raw forward index format for codec pipelines - #19307
Open
xiangfu0 wants to merge 1 commit into
Open
Conversation
This was referenced Aug 19, 2026
xiangfu0
force-pushed
the
xiangfu0/codex/codec-stack/05-v7-format
branch
from
August 20, 2026 09:07
d906d6d to
04dd66f
Compare
xiangfu0
force-pushed
the
xiangfu0/codex/codec-stack/05-v7-format
branch
from
August 21, 2026 00:49
04dd66f to
669848c
Compare
xiangfu0
force-pushed
the
xiangfu0/codex/codec-stack/05-v7-format
branch
from
August 21, 2026 04:16
669848c to
e784709
Compare
xiangfu0
force-pushed
the
xiangfu0/codex/codec-stack/05-v7-format
branch
from
August 24, 2026 09:40
e784709 to
fa07c2c
Compare
xiangfu0
force-pushed
the
xiangfu0/codex/codec-stack/05-v7-format
branch
from
August 25, 2026 04:55
fa07c2c to
74c773d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19307 +/- ##
=============================================
- Coverage 67.55% 57.52% -10.03%
+ Complexity 1430 7 -1423
=============================================
Files 3486 2688 -798
Lines 224100 164280 -59820
Branches 35370 26674 -8696
=============================================
- Hits 151392 94505 -56887
- Misses 60678 61758 +1080
+ Partials 12030 8017 -4013
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
force-pushed
the
xiangfu0/codex/codec-stack/05-v7-format
branch
from
August 25, 2026 20:25
74c773d to
4fe389f
Compare
Base automatically changed from
xiangfu0/codex/codec-stack/04-t64-gorilla
to
master
August 25, 2026 21:20
xiangfu0
force-pushed
the
xiangfu0/codex/codec-stack/05-v7-format
branch
3 times, most recently
from
August 25, 2026 22:54
7520945 to
598b44a
Compare
xiangfu0
requested review from
Jackie-Jiang and
yashmayya
and
a lite review from Copilot
August 26, 2026 01:49
xiangfu0
force-pushed
the
xiangfu0/codex/codec-stack/05-v7-format
branch
3 times, most recently
from
August 28, 2026 09:11
236b5a3 to
00bceb0
Compare
The legacy fixed-byte layout cannot encode a codec pipeline or self-identify a new reader format. Add a V7 header with explicit magic and the canonical codec specification so readers can dispatch safely and validate every frame. Route every non-null codecSpec to V7 and reserve legacy formats for legacy compression configuration. Validate RAW single-value INT/LONG columns and exact chunk bounds during table-config validation, and reconcile format changes during reload. V7 is forward-only across mixed versions: upgrade all segment builders and readers before enabling codecSpec. Before a binary rollback, remove codecSpec and rewrite affected forward indexes to a legacy format. Cover corruption, released legacy fixtures, validation, reload transitions, and offline/realtime clusters with real metadata and segments.
xiangfu0
force-pushed
the
xiangfu0/codex/codec-stack/05-v7-format
branch
from
August 29, 2026 09:08
00bceb0 to
175ac1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codecSpecin its header.codecSpec, including plainLZ4,SNAPPY,GZIP, andZSTD, through V7. Legacy compression configuration still selects legacy formats.Compatibility
This is an on-disk upgrade boundary. Upgrade every component that may build or read segments before enabling
codecSpec. Before a binary rollback, removecodecSpecand reload or regenerate affected V7 forward indexes into a legacy format.Verification
Stack
#19306 is merged. This PR now owns V7 selection, validation, reload reconciliation, and end-to-end coverage. Child PRs #19308 and #19309 need to be rebased parent-first with duplicated behavior removed.