tools: pass TOPDIR in SDIR_template and MAKE_template#19310
Open
Zepp-Hanzj wants to merge 1 commit into
Open
Conversation
SDIR_template and MAKE_template did not pass TOPDIR to recursive makes. When a sub-make needed to include $(TOPDIR)/Make.defs (e.g. to define SDIR_template for further recursion), TOPDIR was missing and the include silently failed via '-include'. Pass TOPDIR in both templates so recursive makes have full access to the build system configuration. Signed-off-by: hanzhijian <hanzhijian@zepp.com>
github-actions
Bot
added
Area: Build system
Size: XS
|
xiaoxiang781216
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SDIR_templateandMAKE_templateintools/Config.mkdid not passTOPDIRto recursive makes. When a sub-make needed to include$(TOPDIR)/Make.defs(e.g. to defineSDIR_templatefor further recursion into nested subdirectories),TOPDIRwas missing and the include silently failed via-include.Changes
Pass
TOPDIRin both templates so recursive makes have full access to the build system configuration.Motivation
Companion PR for apache/nuttx-apps#3585 which fixes distclean for partial builds. Without TOPDIR being passed, the distclean targets defined inline in Directory.mk cannot recurse into sub-subdirectories.
Signed-off-by: hanzhijian hanzhijian@zepp.com