examples: nrf24l01_term: reserve RX terminator#3604
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
xiaoxiang781216
approved these changes
Jul 6, 2026
read_pkt() terminates the received payload with buff[ret], but a full-size read can leave no room for that trailing NUL byte. Limit the read length to one byte less than the buffer size so the received payload remains safely terminated before it is printed. Signed-off-by: Old-Ding <ai.neo.ae86@gmail.com>
Old-Ding
force-pushed
the
codex/nrf24l01-term-rx-terminator
branch
from
c6724c8 to
d9c3d5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sizeof(buff) - 1.buff[ret] = '\0'terminator.Root cause
buffis declared asNRF24L01_MAX_PAYLOAD_LEN + 1, butread_pkt()requestedsizeof(buff)bytes before appending a NUL terminator. A full-length read could write the terminator one byte pastbuff.Testing
git diff --checkgit show --stat --check --format=fuller HEADNot run: local compile, because this environment does not have
make,cmake,gcc,clang, orccavailable.