Skip to content

examples: xmlrpc: bound header value copy #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Old-Ding wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

examples: xmlrpc: bound header value copy #3602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions examples/xmlrpc/xmlrpc_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@ static int xmlrpc_getheader(FAR char *buffer, FAR char *header,
FAR char *temp;
int i = 0;

if (size <= 0)
{
return -1;
}

temp = strstr(buffer, header);
if (temp)
{
Expand All @@ -150,7 +155,7 @@ static int xmlrpc_getheader(FAR char *buffer, FAR char *header,

/* Copy the rest to the value parameter */

while ((*temp != ' ') && (*temp != '\n') && (i < size))
while ((*temp != ' ') && (*temp != '\n') && (i < size - 1))
{
value[i++] = *temp++;
}
Expand Down Expand Up @@ -213,7 +218,7 @@ static void xmlrpc_handler(int fd)
buffer[max] = 0;

ret = xmlrpc_getheader(buffer, "Content-Length:", value,
CONFIG_EXAMPLES_XMLRPC_BUFFERSIZE);
sizeof(value));
if (ret > 0)
loadlen = atoi(value);
}
Expand Down
Loading