examples: Fix network echo receive terminators#3597
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
The netloop and poll TCP echo examples receive up to IOBUFFER_SIZE bytes and then append a NUL terminator before logging the data. A full-size receive can therefore write one byte past the input buffer. Reserve one extra byte in the buffers that are terminated after recv(). Keep the receive limit and echo length capped at IOBUFFER_SIZE so the data path is unchanged. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
xiaoxiang781216
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The netloop and poll TCP echo examples receive up to
IOBUFFER_SIZEbytes and then append a NUL terminator before logging the received data. A full-size receive can therefore write one byte past the input buffer.Reserve one extra byte for the buffers that are terminated after
recv(), while keeping the receive limit and echo length capped atIOBUFFER_SIZE.Validation
git diff --check origin/master..HEADgit show --check --stat --oneline HEADgit ls-files --eol examples/netloop/lo_main.c examples/netloop/lo_listener.c examples/poll/host.c examples/poll/net_listener.c examples/poll/net_reader.c