examples: nrf24l01_btle: Fix RX terminator bounds#3596
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
nrf24_read() reads up to the nRF24L01 maximum payload length and then appends a NUL terminator for the receive buffer. A full 32-byte payload can therefore write one byte past the local rbuf[32]. Reserve one extra byte for the terminator while keeping the read length capped at NRF24L01_MAX_PAYLOAD_LEN. Dump the number of bytes actually received in the debug path. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
xiaoxiang781216
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NRF24L01_MAX_PAYLOAD_LENWhy
nrf24_read()appends a NUL terminator after reading a packet. The local buffer was exactly 32 bytes, which is the nRF24L01 maximum payload length. A full-size payload can therefore return 32 and makerbuf[ret] = '\0'write one byte past the buffer.Testing
git diff --check origin/master..HEADgit show --check --stat --oneline HEADgcc/clang/makeor WSL/bash shell